DRAFT: Combine aarch64 testing with atomics fix #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests test atomic_compare_exchange_weak_explicit which is allowed
to fail for no clear reason. The test tries to account for this by
detecting output differences, using that to set a weak_exchange_failed
boolean, and using that weak_exchange_failed boolean to detect where the
result of atomic_compare_exchange_weak_explicit does not match
expectations. That is, in output_reference, it does:
if (value == expected_values[success_index]) {
weak_exchange_failed = true;
return true;
}
Then, bool_output_reference is:
[success_index, weak_exchange_failed](size_t index) {
return index == success_index && !weak_exchange_failed;
};
The problem here is that bool_output_reference is constructed capturing
weak_exchange_failed by value, so it will never pick up the updated
value even if it was detected that the weak exchange had failed. To fix
this, capture it by reference instead.
coldav
force-pushed
the
colin/try_aarch64_atomics_fix
branch
from
5101827
to
cd3ef85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Provide a brief overview of what your changes do, summarizing their effects
and consequences.
Reason for change
Describe how the current behaviour of the project is causing problems for you
or is otherwise unsatisfactory for your use case.
Description of change
Describe the intended behaviour your changes are meant to introduce to the
project and explain how they resolve the problem stated above. Detail any
relevant changes that may affect other users of the project, such as
compilation options, runtime flags, expected inputs and outputs, API entry
points, etc.
If you have added new testing, provide details on what tests you have added
and what the purpose of them is.
Anything else we should know?
If there's any other relevant information we should know that may help us in
understanding and verifying your patch, please include it here.
Checklist